Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Javascript confirmation prompt #191

Closed
jcass77 opened this issue Apr 17, 2016 · 0 comments
Closed

Replace Javascript confirmation prompt #191

jcass77 opened this issue Apr 17, 2016 · 0 comments

Comments

@jcass77
Copy link
Member

jcass77 commented Apr 17, 2016

A JavaScript confirmation prompt is displayed when the user tries to delete a stream:

mopidy-musicbox-webclient/mopidy_musicbox_webclient/static/js/controls.js

Line 577 in f43a9a7

if (confirm("Are you sure you want to remove '" + name + "'?")) {

This should probably be replaced with a proper jQuery Mobile popup instead to ensure a more consistent look and feel throughout the application.
jcass77 added a commit to jcass77/Mopidy-MusicBox-Webclient that referenced this issue Apr 27, 2016
@jcass77
fix:Replace JavaScript prompt with jQuery equivalent.
b2f2627 
Fixes pimusicbox#191.
@jcass77 jcass77 mentioned this issue Apr 27, 2016
Merged
jcass77 added a commit to jcass77/Mopidy-MusicBox-Webclient that referenced this issue May 7, 2016
@jcass77
fix:Replace JavaScript prompt with jQuery equivalent.
7b3d17a 
Fixes pimusicbox#191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcass77