Preview mailboxes with telescope #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soywod
reviewed
Apr 6, 2021
soywod
requested changes
Apr 8, 2021
soywod
reviewed
Apr 8, 2021
|
@soywod I updated the himalaya#msg#list-function now, let me know what you think. One thing to point out is that I added a I also change how errors are thrown in |
soywod
requested changes
Apr 8, 2021
|
Looks good to me, I guess we can merge. Thanks for your contribution! |
|
Cool 🎉 I'm happy that I could contribute :) |
koalp
pushed a commit
to koalp/himalaya
that referenced
this pull request
Sep 17, 2021
* Preview mailboxes with telescope * Output error message in preview * Throw error * Refactored himalaya#msg#list and handle errors in telescope preview * Changes based on feedback * Added argument should_throw to cli function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started adding preview of mailboxes using telescope. It works well, see (blurred) screencapture below. The only issue is when a mailbox is empty since there is then an error somewhere in the vimscripts I think. @soywod Is there a way to capture this error or perhaps check beforehand if the mailbox is empty or not?