Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fsp shm caching #360

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Fsp shm caching #360

merged 2 commits into from
Jul 19, 2022

Conversation

goodboy
Copy link
Contributor

@goodboy goodboy commented Jul 19, 2022

Resolves #359.

This has worked super well for me in "production" and seems to generally result in more UI/fsp cluster side stability and general minimized mem use.

goodboy added 2 commits July 19, 2022 09:07
@goodboy
Only 4k seconds of 1s ohlc when no tsdb
90bc9b9
@goodboy
Cache fsp ShmArrays where possible
e0491cf 
Minimize calling `.data._shmarray.attach_shm_array()` as much as is
possible to avoid the crash from #332. This is the suggested hack from
issue #359.

Resolves #359
@goodboy goodboy added bug guille broke it prolly data-layer real-time and historical data processing and storage UI fsp financial signal processing labels Jul 19, 2022
@goodboy goodboy marked this pull request as ready for review July 19, 2022 13:11
goodboy
goodboy commented Jul 19, 2022
View reviewed changes
Copy link
Contributor Author

@goodboy goodboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the few times i put up a small patch that actually substantially makes things better 😂

@goodboy goodboy merged commit f2dba44 into master Jul 19, 2022
@goodboy goodboy deleted the fsp_shm_caching branch July 19, 2022 13:55
@goodboy goodboy mentioned this pull request Aug 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug guille broke it prolly data-layer real-time and historical data processing and storage fsp financial signal processing UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FSP engine task re-syncs should not re-attach to shm
1 participant
@goodboy