Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command + control benchmarks #14

Open
piercefreeman opened this issue Oct 14, 2022 · 0 comments
Open

Command + control benchmarks #14

piercefreeman opened this issue Oct 14, 2022 · 0 comments

Comments

@piercefreeman
Copy link
Owner

piercefreeman commented Oct 14, 2022

Follow up to #12.

One could implement this logic separately in Playwright through request interception. There are a few benefits to this:

  • Inline node support; can make use of global logic and shared data structures
  • Direct communication between browser -> server, no need for a socket based relay. Anecdotally in popdown adding a passthrough MITM server did slow things down.

However, direct Playwright commands have a few drawbacks:

const browser = await chromium.launch({
  // Browser proxy option is required for Chromium on Windows.
  proxy: { server: 'per-context' }
});
const context = await browser.newContext({
  proxy: { server: 'http://myproxy.com:3128' }
})

This ticket tracks writing a benchmark comparing the speed of a separate proxy server versus similar functionality written in Node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant