Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SASS Deprecation Warning #575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix SASS Deprecation Warning #575

wants to merge 1 commit into from

Conversation

indus
Copy link

@indus indus commented Jul 18, 2024

Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in & {}.

More info: https://sass-lang.com/d/mixed-decls

There may be more locations where these changes should be made - but this one is the only one that gives an error in my codebase

> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

> More info: https://sass-lang.com/d/mixed-decls
@pauloxnet
Copy link
Contributor

I came here to propose the same fix. Thanks for doing this already.

bunnymatic pushed a commit to bunnymatic/pico that referenced this pull request Nov 29, 2024
problem
------

we get a pile of css deprecation warnings

solution
------

Follow the instructions from the warnings to get quiet them up.

changes
-------

* Applied Pico PR's (via patch) picocss#575 and picocss#596
* Update sass files to include `sass:color`, `sass:list` etc as required to avoid global methods
* Move from `color.red`, `color.green`, `color.blue` to `color.channel` as suggested by deprecation warnings
* bumped sass to 1.81
* rebuild css (with `yarn build`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants