Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a KNeighborsClassifier #41

Open
binkabir opened this issue Jan 18, 2019 · 7 comments
Open

Implement a KNeighborsClassifier #41

binkabir opened this issue Jan 18, 2019 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@binkabir
Copy link

binkabir commented Jan 18, 2019

KNeighborsClassifier seems to be a very popular classification algorithm.
Do you have any plans/timeline for implementing it?

Cheers.

@inejc
Copy link
Member

inejc commented Jan 18, 2019

Hey. No particular timeline but would be a welcome contribution. Would you perhaps be interested in tackling this? Let me know if you need any help 🙂.

@inejc inejc added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 18, 2019
@binkabir
Copy link
Author

Hi @inejc. I will be willing to help in some algorithm implementation like this one, but Im only good in scala programming and a beginner in ML.

@inejc
Copy link
Member

inejc commented Jan 18, 2019

@binkabir that's perfectly fine, you are in a very good position if you know scala 🙂. There are plenty of resources available for free online and I can provide additional help with the actual algorithm. A good start would be to learn how it works. Let me know if you need any help finding the learning material.

@binkabir
Copy link
Author

Sure, I have some materials, but having you giving me more learning materials will be awesome.

@inejc
Copy link
Member

inejc commented Jan 18, 2019

Great, I'll provide some additional links over the weekend.

@inejc
Copy link
Member

inejc commented Jan 22, 2019

Hi @binkabir. For a quick overview of the algorithm I would suggest these resources:

After that, it would be useful to study the following data structures:

Let me know if you need more math-heavy resources for the above and I'll do my best to provide them. You can also try to search for them on Google Scholar.

Note that estimators in doddle-model are implemented using typeclasses. If you are not familiar with them, you can take a look at:

You can find the basic doddle-model typeclasses here. If you decide to implement the classification algorithm you will need to implement an instance of the Classifier typeclass. Here is an example of how this is done for the most frequent (dummy) classifier.

Don't hesitate to ask if you need any more help and thanks for being interested in making a contribution, it's really appreciated.

@binkabir
Copy link
Author

This is awesome, will have a look at it. Thanks.

@inejc inejc removed the good first issue Good for newcomers label Feb 23, 2019
@inejc inejc changed the title Implementation of KNeighborsClassifier Implement a KNeighborsClassifier Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants