You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
svenmuennich opened this issue
May 30, 2017
· 0 comments
Labels
bugIssues that describe an unexpected behaviour in an existing functionality.major"bug" issues that completely break a business process, with no reasonable workaround available.
When configuring the shop to charge no VAT and having a payment method with a percentage surcharge, the respective surcharge position in the basket contains VAT. This is caused by adding a wrong surcharge position in sBasket::sInsertSurchargePercent(), although a correct position was already added by sAdmin::handlePaymentMeanSurcharge().
To me sBasket::sInsertSurchargePercent() seems obsolete, since it only calculates percentage payment method discounts. So removing this method might just fix it.
The text was updated successfully, but these errors were encountered:
svenmuennich
added
bug
Issues that describe an unexpected behaviour in an existing functionality.
major
"bug" issues that completely break a business process, with no reasonable workaround available.
labels
May 30, 2017
bugIssues that describe an unexpected behaviour in an existing functionality.major"bug" issues that completely break a business process, with no reasonable workaround available.
When configuring the shop to charge no VAT and having a payment method with a percentage surcharge, the respective surcharge position in the basket contains VAT. This is caused by adding a wrong surcharge position in
sBasket::sInsertSurchargePercent()
, although a correct position was already added bysAdmin::handlePaymentMeanSurcharge()
.To me
sBasket::sInsertSurchargePercent()
seems obsolete, since it only calculates percentage payment method discounts. So removing this method might just fix it.The text was updated successfully, but these errors were encountered: