Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage payment surcharge is calculated wrong #40

Open
svenmuennich opened this issue May 30, 2017 · 0 comments
Open

Percentage payment surcharge is calculated wrong #40

svenmuennich opened this issue May 30, 2017 · 0 comments
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. major "bug" issues that completely break a business process, with no reasonable workaround available.

Comments

@svenmuennich
Copy link
Member

When configuring the shop to charge no VAT and having a payment method with a percentage surcharge, the respective surcharge position in the basket contains VAT. This is caused by adding a wrong surcharge position in sBasket::sInsertSurchargePercent(), although a correct position was already added by sAdmin::handlePaymentMeanSurcharge().

To me sBasket::sInsertSurchargePercent() seems obsolete, since it only calculates percentage payment method discounts. So removing this method might just fix it.

@svenmuennich svenmuennich added bug Issues that describe an unexpected behaviour in an existing functionality. major "bug" issues that completely break a business process, with no reasonable workaround available. labels May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. major "bug" issues that completely break a business process, with no reasonable workaround available.
Projects
None yet
Development

No branches or pull requests

1 participant