Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overwriting instock when saving an article in the backend #39

Open
3 tasks
fixpunkt opened this issue May 23, 2017 · 5 comments
Open
3 tasks

Prevent overwriting instock when saving an article in the backend #39

fixpunkt opened this issue May 23, 2017 · 5 comments
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".

Comments

@fixpunkt
Copy link
Member

fixpunkt commented May 23, 2017

We think that this process causes instock errors:

  1. Open article detail view.
  2. Article gets ordered, which decreases the instock.
  3. Save the article view.
  • Verify that this is actually the case
  • Make a PR
  • Monkey-patch into Shopware from ERP.
@fixpunkt fixpunkt added bug Issues that describe an unexpected behaviour in an existing functionality. major "bug" issues that completely break a business process, with no reasonable workaround available. labels May 23, 2017
@maximilianoster
Copy link

I just add the reference to https://github.com/VIISON/ShopwarePickwareERP/issues/383#issuecomment-278656645 as we already discussed the problem and a possible solution there.

@samuelvogel
Copy link
Member

samuelvogel commented Sep 4, 2017

We already "monkey-patched" this in Shopware ERP powered by Pickware plugin.

We also want to have something similar for customer orders and also Pickware supplier orders. For articles it's just the easiest, since the field changetime is already present is s_articles (but it's not always updated yet, especially not when frontend orders change the instock).

@windaishi
Copy link

I would do anything for Pickware, but I won't do that...
(Actually I already did the SW pull request for this shopware/shopware#1474)

@fixpunkt
Copy link
Member Author

Actually, I don't think the case described in this issue is actually fixed by shopware/shopware#1474. Have you tested that?

@windaishi windaishi self-assigned this Feb 20, 2018
@windaishi
Copy link

windaishi commented Feb 20, 2018

Okay, I started an instance and tested the article overwrite protection. Since the protection currently only works only for s_article and not s_article_details, the protection is not triggered in that case.
Therefore we need a timestand on a s_article_details level.
Since this is monkey patched in ERP already, this is only a problem in the plain SW installation.

@svenmuennich svenmuennich added minor "bug" issues that are neither "critical" nor "major". and removed major "bug" issues that completely break a business process, with no reasonable workaround available. labels Feb 23, 2018
@windaishi windaishi removed their assignment May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".
Projects
None yet
Development

No branches or pull requests

5 participants