Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading photos downloads version with editions undone #323

Open
WhyNotHugo opened this issue Feb 15, 2021 · 1 comment · May be fixed by #347
Open

Downloading photos downloads version with editions undone #323

WhyNotHugo opened this issue Feb 15, 2021 · 1 comment · May be fixed by #347

Comments

@WhyNotHugo
Copy link
Contributor

WhyNotHugo commented Feb 15, 2021

The problem

On iOS:

  1. Take a screenshot.
  2. Annotate it (e.g.: cribble on it with your finger).
  3. Let it sync to iCloud.

On the desktop:

  1. Fetch the photo via iCloud pyicloud

Expected result

I'd expect the same image I see on my phone or on other iCloud devices

Actual result

The image I get doesn't have the annotation I did.

Other notes

The same things happen if I save a photo to my phone, and then crop it. The one fetch via pyicloud is the uncropped version, but everywhere else on iCloud I see the cropped version.

This is also an issue with month-old photos, so it's not a lag-in-eventual-consistency issue.

I suspect that resOriginal means "original unedited image", wheras one usually want the "latest edited original", to so call it.

Environment

$ pip show pyicloud
Name: pyicloud
Version: 0.10.2
Summary: PyiCloud is a module which allows pythonistas to interact with iCloud webservices.
Home-page: https://github.com/picklepete/pyicloud
Author: None
Author-email: None
License: MIT
Location: /home/hugo/.cache/virtualenvs/photos/lib/python3.9/site-packages
Requires: keyrings.alt, tzlocal, pytz, click, future, keyring, six, certifi, requests
Required-by:
$ python -V
Python 3.9.1
$ uname -srmo
Linux 5.10.16-arch1-1 x86_64 GNU/Linux 
  • Don't know if previous releases had this issue since 2FA was not supported until recently.
@jcass77 jcass77 linked a pull request Sep 2, 2021 that will close this issue
12 tasks
@jcass77
Copy link

jcass77 commented Sep 2, 2021

#347 should fix this, please try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants