Admin interface reports "DNS Service not running" when pihole-FTL runs on a non-standard port.

[svc-user]

Versions

• Pi-hole version is v5.6 (Latest: v5.6)
• AdminLTE version is v5.8 (Latest: v5.8)
• FTL version is v5.11 (Latest: v5.11)

Platform

• OS and version: Debian 11

• Platform: VPS

Expected behavior

I expect the admin interface to report the DNS Service (pihole-FTL) to be running, when it is in fact running and functioning.

Actual behavior / bug

The admin interface reports "DNS service not running" under Status in the side-menu.

Steps to reproduce

Steps to reproduce the behavior:

Change pihole-FTL to run on a non-standard port (something not port 53).

1. Open /etc/dnsmasq.d/01-pihole.conf
2. Add the line port=12345 in the config.
3. Restart the pihole-FTL service (# systemctl restart pihole-FTL)

Debug Token

• URL:

N/A

Screenshots

Additional context

Issue occurs on line 319 of the pihole script where it's checked if the service is listening on port 53 instead of checking if the service is running.

[yubiuser]

Thanks for the report. Fixing the "issue" is not a problem, however, I would like to discuss if we really should fix this. DNS runs by default on port 53. If users are so advanced to change the port to something different, they need an advanced network knowledge and configuration.
If we fix this (checking if pihole is running at all or comparing the configured port with the actual port) we might hide user "misconfigurations" where they configured another port without fully understand the implications. For them the message is useful - in the regard to check their configuration again.

One way out would be to simply change the message to "DNS service not running on port 53" - but I'm not sure if this is what you aimed for.

[svc-user]

I didn't have a direct aim. I understand the "fix" is easy, and I half expected a response along the lines of that you gave me. Which I'm completely okay with. I totallyssee where you're coming from.
May I suggest the status, if pihole-FTL is running, could be "DNS service running on port 1234"? Or maybe only add the port part if it's a non-standard port.
Tbh this is partially a non-issue, since the software works as expected, from a configuration viewpoint, but it's a thorn in my eye that the interface doesn't agree 😅

[yubiuser]

@bdoner

Please try if

pihole checkout core tweak/web_status and pihole checkout web tweak/web_status fix the issue for you.

You can got back to the master branch by pihole checkout master

[svc-user]

Hi @yubiuser,

It looks really good on my end. I have left a single comment to your PR. But apart from that nothing to note :)

[yubiuser]

Fix has been released to master with
https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1