Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All manual whitelist and blacklist after update to 5.1.1 ... GONE #1530

Closed
3 tasks done
foresthus opened this issue Jul 16, 2020 · 14 comments
Closed
3 tasks done

All manual whitelist and blacklist after update to 5.1.1 ... GONE #1530

foresthus opened this issue Jul 16, 2020 · 14 comments

Comments

@foresthus
Copy link

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

{Replace this with a number from 1 to 10. 1 being not familiar, and 10 being very familiar}


Expected behavior:
Whan I add a fqdn or "regular expression" in a whitelist or blacklist pihole gives back, that it is now added. This is crazy because nothing is shown. All entries for whirelists or blacklists are not listed anymore.
{A detailed description of what you expect to see}
There should be lists shown in blacklists or whitelists, if I add them.
Actual behavior:

{A detailed description and/or screenshots of what you do see}

Steps to reproduce:
allways
{Detailed steps of how we can reproduce this}

Debug token provided by uploading pihole -d log:

{Alphanumeric token}

Troubleshooting undertaken, and/or other relevant information:

{Steps of what you have done to fix this}

  • {Please delete this quoted section when opening your issue}
  • You must follow the template instructions. Failure to do so will result in your issue being closed.
  • Please submit any feature requests here, so it is votable and trackable by the community.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.
  • Detail helps us understand and resolve an issue quicker, but please ensure it's relevant.
  • This template was created based on the work of udemy-dl.
@PromoFaux
Copy link
Member

We are going to need a bit more to go on...

Screenshots / logs/ debug token please

@braverat35
Copy link

Same issue here

updated from 5.0 to 5.1.1

  • whitelist and blacklist is gone
    image
  • Disabling pihole does not work
  • chart overview is not loading
    image

Debug token : https://tricorder.pi-hole.net/f598rxavxr

@yubiuser
Copy link
Member

yubiuser commented Jul 17, 2020

I've seen this on discourse with a German user as well. "Somehow" it resolved itself.
Please check, if they are still in the database and this is solely an display issue

sqlite3 /etc/pihole/gravity.db --header --column "Select * from domainlist"

@braverat35
Copy link

They are still in the SQLite database, and also get added if you enter a new one, yust not displayed

@PromoFaux
Copy link
Member

PromoFaux commented Jul 17, 2020

Ctrl + F5.... it's (likely) a cached javascript issue

@foresthus
Copy link
Author

Hi, I tried a complete nee install via the method via git. The install was Fine, but the restore was Quote confusing for me. The restore said that all Black and whitelists and the other Thinge were restored. After cleaning my cache I loggende back to the admin-Gui. Only the Domainlists were imported. What should I do now?

@cliff-wakefield
Copy link

cliff-wakefield commented Jul 17, 2020

Same issue here

updated from 5.0 to 5.1.1

  • chart overview is not loading

Same here, but a force refresh in the browser fixes it.

@kronflux
Copy link

Can confirm the issue itself(upgrade caused whitelist page to appear blank), and the solution (forcing a full refresh and/or clearing browser cache)

@foresthus
Copy link
Author

Hi folks, thnx 4 all you placed your posts here. I reinstalled pihole, I cleared all my cache, I made all updates via cli and after that everything was back to normal. Everything was shown and I could manage to restore my backup aswell.
Therefor all ok again.
Thnx 2 all

@javierin
Copy link

Ctrl F5 fixed it for me as well

@boecko
Copy link

boecko commented Jul 26, 2020

Couldn't be this resolved quite easily with an cachebuster-queryarg in the <script/<stylesheet urls?
For example, instead of

<script src="scripts/pi-hole/js/footer.js"></script>

you could use

<script src="scripts/pi-hole/js/footer.js?v=5.1.1"></script>

@dschaper dschaper transferred this issue from pi-hole/pi-hole Jul 26, 2020
@XhmikosR
Copy link
Contributor

It's already sorted upstream in core. It should not happen again starting with the next release.

@XhmikosR XhmikosR removed their assignment Jul 27, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@yubiuser
Copy link
Member

Should be fixed by #1550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants