Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Domain is not clickable in the Top Blocked Domains widget #1241

Closed
3 tasks done
erigul opened this issue May 6, 2020 · 8 comments
Closed
3 tasks done

Empty Domain is not clickable in the Top Blocked Domains widget #1241

erigul opened this issue May 6, 2020 · 8 comments

Comments

@erigul
Copy link

erigul commented May 6, 2020

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

1


Expected behaviour:

In the "Top Blocked Domains" box on the homepage an entry for queries to the empty domain (string "") should somehow be clickable and take me to /admin/queries.php?domain=

Actual behaviour:

The entry for the empty domain shows up in the list, but as there is no text in the field it's actually not clickable. If I inspect the DOM I see a <a href="queries.php?domain="></a> is added, but with no text there it's not clickable.

Steps to reproduce:

Reproducible anytime queries to the empty domain shows up in the Top Blocked Domains widget.

Debug token provided by uploading pihole -d log:

N/A

Troubleshooting undertaken, and/or other relevant information:

N/A

@dschaper
Copy link
Member

dschaper commented May 6, 2020

Debug token please.

@PromoFaux
Copy link
Member

I'm not entirely sure how an empty domain is even queried or added to the query log.. @DL6ER, any thoughts?

@dschaper
Copy link
Member

dschaper commented May 6, 2020

Might not be "empty" but just the . root.

@erigul
Copy link
Author

erigul commented May 6, 2020

Yes, if I run a nslookup . I get an empty domain entry in my query log

@yubiuser
Copy link
Member

yubiuser commented May 6, 2020

Some work has been put into a feature request improving the link dashboard -> stats. This might be the right place to bring this issue up:
https://discourse.pi-hole.net/t/improve-dashboard-stats-link-to-query-log/30653

@PromoFaux
Copy link
Member

I've actually got a quick fix for this, which I need to code up and do a PR for, may not make it into v5, but if not it will follow shortly after in v5.1

@PromoFaux
Copy link
Member

This is fixed in version 5.0

@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/regex-for-blocking-just-dot-as-domain/57319/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants