-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty Domain is not clickable in the Top Blocked Domains widget #1241
Comments
Debug token please. |
I'm not entirely sure how an empty domain is even queried or added to the query log.. @DL6ER, any thoughts? |
Might not be "empty" but just the |
Yes, if I run a |
Some work has been put into a feature request improving the link dashboard -> stats. This might be the right place to bring this issue up: |
I've actually got a quick fix for this, which I need to code up and do a PR for, may not make it into v5, but if not it will follow shortly after in v5.1 |
This is fixed in version 5.0 |
This issue has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/regex-for-blocking-just-dot-as-domain/57319/9 |
In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}
How familiar are you with the the source code relevant to this issue?:
1
Expected behaviour:
In the "Top Blocked Domains" box on the homepage an entry for queries to the empty domain (string "") should somehow be clickable and take me to
/admin/queries.php?domain=
Actual behaviour:
The entry for the empty domain shows up in the list, but as there is no text in the field it's actually not clickable. If I inspect the DOM I see a
<a href="queries.php?domain="></a>
is added, but with no text there it's not clickable.Steps to reproduce:
Reproducible anytime queries to the empty domain shows up in the Top Blocked Domains widget.
Debug token provided by uploading
pihole -d
log:N/A
Troubleshooting undertaken, and/or other relevant information:
N/A
The text was updated successfully, but these errors were encountered: