Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Time FTL started to show the date too #1108

Closed
XhmikosR opened this issue Dec 28, 2019 · 4 comments
Closed

Change Time FTL started to show the date too #1108

XhmikosR opened this issue Dec 28, 2019 · 4 comments

Comments

@XhmikosR
Copy link
Contributor

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

1


I think it would make more sense to show the date and time FTL was started. After one day, currently only the date is shown. We could probably add this in a time element https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time like:

<time datetime="2019-12-28T17:49:13+02:00" title="Sat, 28 Dec 2019 17:49:13 +0200">28 December 2019</time>

maybe without the timezone, but you get the idea.

Not sure if the info FTL returns contains the date too, I just thought I'd report this.

@DL6ER
Copy link
Member

DL6ER commented Dec 28, 2019

This field shows the output of

ps -p $(pidof pihole-FTL) -o start

which does not include the time (see here). We could maybe change this to showing the last modification date of the PID file, but we need some further discussion if this is truly equivalent.

@yubiuser
Copy link
Member

Use
ps -p $(pidof pihole-FTL) -o lstart instead

source: https://www.shellhacks.com/linux-ps-command-get-process-start-time-date/

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@yubiuser
Copy link
Member

Has been fixed a long time ago with #1501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants