Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a function to remove undesired text from sys_model to improve code readability #317

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?:

Simplify the code and improve maintenance and readability.

How does this PR accomplish the above?:

Replacing many lines using shell parameter substitutions with a function (using awk) to clean up the string.

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

to improve code readability.

Signed-off-by: RD WebDesign <[email protected]>
NOTE: We couldn't find these strings in any tested hardware

Signed-off-by: RD WebDesign <[email protected]>
@yubiuser yubiuser merged commit cd0ad3a into development Dec 28, 2022
@yubiuser yubiuser deleted the filter_sys_model2 branch December 28, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants