-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use getFTLPID
instead of pidof
#313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rdwebdesign
requested changes
Dec 26, 2022
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. |
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
rdwebdesign
previously approved these changes
Dec 28, 2022
Signed-off-by: Christian König <[email protected]>
Added a small visual improvement. |
DL6ER
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Currently, we use
pidof
to test ifFTL
is running. However, there are hints thatpidof
might be a bit unreliable to find all processes. See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=926896 and https://unix.stackexchange.com/questions/518411/why-is-pidof-not-workingThis as also been reported in one of our issues: #307 (comment)
How does this PR accomplish the above?:
pidof
withgetFTLPID
, a function that we also use incore
. It'll read thePID
frompihole-FTL.pid
fileFTL
writes on it's start.h
option to theps
command for gettingFTL
s CPU and memory utilization to save one pipe totail
.By submitting this pull request, I confirm the following:
git rebase
)