Automatically center PADD output on screen #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdwebdesign
force-pushed
the
center_option
branch
from
ff99c3f to
55ffb9e
Compare
Merged
yubiuser
reviewed
Dec 4, 2022
yubiuser
reviewed
Dec 4, 2022
|
My honest option is that centering should be the default with an option to disable centering. Users that just update PADD will probably not look up new options and not realize it. (actually, I doubt more than 1% even ever looks if there are any options at all) In my feeling, this is a feature for the masses and, as such, it seems to be default-behavior-worthy. |
|
I like the idea to make this the new default. We would need options like |
|
If the I can change the behavior to not center if |
|
I think this is a good idea. |
yubiuser
reviewed
Dec 4, 2022
yubiuser
changed the title
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
- reorder steps inside SizeChecker(); - remove unnecessary variables; - change help text; - add `moveXOffset` before the `PrintLogo` function Signed-off-by: RD WebDesign <[email protected]>
rdwebdesign
force-pushed
the
center_option
branch
from
77c8ce4 to
a69a474
Compare
yubiuser
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Add an option to automatically center PADD output on screen
How does this PR accomplish the above?:
Adding code to calculate
xOffsetandyOffsetand using the new code added on #268Link documentation PRs if any are needed to support this PR:
none
By submitting this pull request, I confirm the following:
git rebase)