-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the print functions #257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a453eda
to
f44bae9
Compare
793dde7
to
0b4351c
Compare
Merged
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
… print functions. This should make it easier to spot misalignments and outputs that are bigger than the minimal screen sizes Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
5414d1b
to
2dd7a81
Compare
Signed-off-by: Christian König <[email protected]>
rdwebdesign
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No visual problems found.
dschaper
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
This PR serves multiple purposes.
CleanEcho
andCleanPrintf
functions. Both were introduced with Eliminate flashing by repainting rather than replacing #74. They solved the issue that after re-sizing the screen artifacts could remain.CleanPrintf
did not serve any purpose, it was rather an intermediate state during this initial PR and was kept because it fitted theCleanEcho
function well. The "cleaning" was done in the format string of theprintf
function with\e[0K
already.CleanEcho
was broken since Multiple Issues Fixed. PLEASE SEE COMMENT! #106, as the line needs clearing after the new output was written, not before.${clean_line}
which does the same as the old\e[0K
but with the (more generic)\e033[0K
CleanEcho
toprintf
functionsPrintLogo()
is now duplicated (once in this functions and once separated for each screen size) but this is a minor drawback.By submitting this pull request, I confirm the following:
git rebase
)