Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use padd.sh URLs #213

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Use padd.sh URLs #213

merged 2 commits into from
Jan 15, 2023

Conversation

dschaper
Copy link
Member

@dschaper dschaper commented Apr 7, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Move to https://install.padd.sh URL.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update, clean and fix the wiki before merging this to master

README.md Outdated Show resolved Hide resolved
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L7: The image does not exist anymore.

Additionally, before we merge this, we need to update the wiki as well (contains old links...)

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

Existing merge conflicts have not been addressed. This PR is considered abandoned.

@github-actions github-actions bot closed this Jan 8, 2023
@rdwebdesign
Copy link
Member

Should we reopen this PR?

@dschaper
Copy link
Member Author

dschaper commented Jan 8, 2023

That's up to you all, the domain is there and available to use.

@rdwebdesign
Copy link
Member

I will reopen the PR.

My opinion is: we should use the domain.
As always, I want to hear the opinion of the other team members.

@rdwebdesign rdwebdesign reopened this Jan 8, 2023
@github-actions github-actions bot removed the Stale label Jan 9, 2023
@rdwebdesign
Copy link
Member

rdwebdesign commented Jan 15, 2023

The proposed change on this PR is simple, but there are a lot of conflicts here.

Note:
https://install.padd.sh is already used on docker-pi-hole.

@github-actions
Copy link

Conflicts have been resolved.

@PromoFaux PromoFaux changed the base branch from master to development January 15, 2023 19:25
@PromoFaux PromoFaux merged commit 3d6a6d1 into development Jan 15, 2023
@PromoFaux PromoFaux deleted the meta/new_home branch January 15, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants