Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use netcat to communicate with FTL's telnet API #210

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

yubiuser
Copy link
Member

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Re-done of #185.

@yubiuser yubiuser requested a review from a team March 25, 2022 17:57
@dschaper
Copy link
Member

It is nice to get away from bashisms so we can be more POSIX.

@yubiuser yubiuser merged commit e66a03c into development Mar 25, 2022
@yubiuser yubiuser deleted the netcat branch March 25, 2022 18:39
@yubiuser yubiuser mentioned this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants