Error when started from r/o directory

[stan-qaz]

*Before submitting a bug report, are you using a test version of Pi-hole? No, release version

Describe the bug
I get an error message under the usual text block that blinks in and out.

CPU Temp: 104.4°F CPU Load: 0.07, 0.02, 0.03 CPU Load: [··········] 1.8% /home/pi/bin/padd.sh: line 536: ./piHoleVersion: Permission denied
/home/pi/bin/padd.sh: line 420: ./piHoleVersion: Permission denied

Steps to reproduce the behavior:

1. Change to /etc
2. Run PADD /home/pi/bin/padd.sh

Expected behavior
No error message

Additional context
If you cd to the pi home directory all is well.

[tgjohnst]

Looks like this is due to the fact that the piHoleVersion file (used to check for updates) is created in the working directory, which in your case is read-only.

If @jpmck thinks it's appropriate, it would be pretty simple to change the script's behavior to always create the piHoleVersion file in the same directory as the piHole script (i.e. replace references to piHoleVersion and ./piHoleVersion with $(dirname "$0")/piHoleVersion ), but I'm not sure this is a desired behavior so won't push a PR yet.

[Bogdan107]

Proposal: create piHoleVersion file under the /tmp directory.

This padd-3.6.2.sh.patch do:

1. Improve ${PIHOLEVERSION} variable.
   With this one each can specify in one place where piHoleVersion file must be placed.
2. Change /sbin/ip to ip.
   My system has /bin/ip file, not /sbin/ip.
3. Add double quotes in write it all to the file part of GetVersionInformation() function.

[thomasmerz]

This makes sense to me. The linked PR #168 will fix/correct this 👍🏻