Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVFAIL reply status wrong #1233

Closed
r2ixuz opened this issue Oct 27, 2021 · 3 comments
Closed

SERVFAIL reply status wrong #1233

r2ixuz opened this issue Oct 27, 2021 · 3 comments

Comments

@r2ixuz
Copy link

r2ixuz commented Oct 27, 2021

SERVFAIL answers from upstream DNS are shown as "N/A" in the "Reply" column.

You can test it with https://dnssec.vs.uni-due.de/ : The domain sigfail.verteiltesysteme.net should return SERVFAIL.

This error is new since "Docker Tag 2021.10.1 Pi-hole v5.6 FTL v5.11 Web Interface v5.8".

@yubiuser
Copy link
Member

Confirm this behavior.

dig sigfail.verteiltesysteme.net

; <<>> DiG 9.17.18-1+ubuntu18.04.1+isc+1-Ubuntu <<>> sigfail.verteiltesysteme.net
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id: 9607
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1472
;; QUESTION SECTION:
;sigfail.verteiltesysteme.net.	IN	A

;; Query time: 192 msec
;; SERVER: 10.0.1.5#53(10.0.1.5) (UDP)
;; WHEN: Wed Oct 27 1
```9:30:25 CEST 2021
;; MSG SIZE  rcvd: 57
Oct 27 19:30:25 dnsmasq[11217]: query[A] sigfail.verteiltesysteme.net from 10.0.1.39
Oct 27 19:30:25 dnsmasq[11217]: forwarded sigfail.verteiltesysteme.net to 127.0.0.1
Oct 27 19:30:25 dnsmasq[11217]: reply error is SERVFAIL

["1635355825","A","sigfail.verteiltesysteme.net","ThinkPad-X230.fritz.box","2","0","0","0","N\/A","-1","localhost#5335",""]

The data form the API already contains N/A. Moving to FTL.

@yubiuser yubiuser transferred this issue from pi-hole/web Oct 27, 2021
@DL6ER
Copy link
Member

DL6ER commented Oct 27, 2021

Thanks for your report. The issue was that we did not compute the reply time for queried errored upstream. The API interprets this as "oh, no reply time = no reply was received" and sends REPLY_UNKNOWN which is then interpreted as N/A.

This should be fixed by #1234

@r2ixuz
Copy link
Author

r2ixuz commented Oct 28, 2021

Can confirm, it is fixed with

Docker Tag fix_cached_cname_upstream_dest
Pi-hole vDev (development, v5.4-50-g8713135)
FTL vDev (fix/cached_cname_upstream_dest, vDev-9102ea9)
Web Interface vDev (devel, v5.6-75-g98ec9ee)

Thank you!

@r2ixuz r2ixuz closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants