Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use two different divs for mobile and desktop instead of a JS solution #1284

Merged
merged 3 commits into from
Nov 8, 2020
Merged

Conversation

Th3M3
Copy link
Contributor

@Th3M3 Th3M3 commented May 13, 2020

Signed-off-by: Th3M3 [email protected]
Co-Authored-By: XhmikosR [email protected]

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Reduce need of js code.

This replaces #1264.

How does this PR accomplish the above?:

Add a separate domain input form and toggle them depending on the screen's width.

What documentation changes (if any) are needed to support this PR?:

-

@DL6ER DL6ER requested a review from XhmikosR May 13, 2020 16:34
@XhmikosR
Copy link
Contributor

Thanks for the PR, I haven't forgotten about it, I'll get to test it this week hopefully.

PromoFaux
PromoFaux previously approved these changes May 27, 2020
@PromoFaux PromoFaux dismissed their stale review May 27, 2020 09:38

Merge conflicts

@PromoFaux
Copy link
Member

Please resolve merge conflicts, thanks!

Proposed changes work well

@Th3M3
Copy link
Contributor Author

Th3M3 commented May 30, 2020

@PromoFaux Ok, done.

@XhmikosR
Copy link
Contributor

This should be simplified later. There's no reason for us not to use unique classes in the buttons.

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants