Bug: when exporting a phylogeny as Newick, spaces in leaf node labels are ignored

[gaurav]

There's an odd bug that comes up when using Phylotree to export its phylogeny as Newick: while internal node labels export fine, leaf node label become concatenated with themselves (e.g. "Mitthyridium undulatum" would become "Mitthyridium undulatumMitthyridiumundulatum"). We currently work around this ourselves, but we should come up with a minimum example that shows this issue and post an issue to Phylotree so they can fix it.

[hlapp]

I think you can still post it to Phylotree now, and update later if and once we can define a test case? That way they know about its existence, and it's also possible that one of the developers can intuit what the cause might be.

[gaurav]

See if Phylotree update fixes it, otherwise remove from Klados v1.0

[gaurav]

I've figured out where the bug is in phylotree.js and have reported it to them: veg/phylotree.js#438. They didn't respond in the last week, so I've put in a PR that will fix the issue for us: veg/phylotree.js#441

[gaurav]

There was a bug in my previous attempt to fix this. I've reported this to phylotree.js at veg/phylotree.js#450 and created a PR to fix it at their end at veg/phylotree.js#448. Once that's fixed, I'll incorporate it in Klados as part of PR #312 and close this issue.