Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Grid for Card layout #191

Open
Xaviju opened this issue Jun 1, 2021 · 4 comments
Open

CSS Grid for Card layout #191

Xaviju opened this issue Jun 1, 2021 · 4 comments

Comments

@Xaviju
Copy link

Xaviju commented Jun 1, 2021

I'd like to know why this repo is not using CSS grid for card layout instead of flex.

Current code displays the grid using flex as here: https://github.com/phuoc-ng/csslayout/blob/88200a698329be14ddc916053266ac788697de8f/client/patterns/card-layout/Details.tsx#L36

Instead, it would be simpler and more powerful to implement grid as:

.cards {
  display: grid;
  gap: 1rem;
  grid-template-columns: repeat(4, 1fr);
}

Am I missing something?

I'll be happy to PR this if you agree.

@Xaviju
Copy link
Author

Xaviju commented Jun 1, 2021

This issue affects also this pattern: https://csslayout.io/patterns/simple-grid/

@pragyamishra56
Copy link

@Xaviju If it would be possible then can you assign me to this issue I want to resolve this would be my first contribution

@Xaviju
Copy link
Author

Xaviju commented Oct 6, 2023

Sorry @pragyamishra56 this is not my repo. This issue was a suggestion to refactor an element layout that has never been responded by the repo owner. You should contact @phuocng

@pragyamishra56
Copy link

@Xaviju How to contact @phuocng to him
If you have any good first issues, could you please let me know Sir? I'm new to open source and eager to make contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants