Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain Default LogLevel #97

Open
phptek opened this issue Jul 7, 2024 · 0 comments
Open

Constrain Default LogLevel #97

phptek opened this issue Jul 7, 2024 · 0 comments

Comments

@phptek
Copy link
Owner

phptek commented Jul 7, 2024

If user's don't modify their project's reporting levels, then the module defaults to the most verbose reporting level (Logger::Debug) which has deleterious effects on data-storage requirements of aggregation backends.

In order to ascertain how best to patch this, we need to get an idea of how the upstream sentry/sentry package treats configured severities e.g. given a project configured with INFO which is correct?

a). Only sends INFO messages to Sentry
b). Sends INFO + (And above) messages to Sentry

See:

public static function from_error(string $severity): string

This ticket therefore covers the following:

  1. Fix areas of SentryHandler and SentryLogger which don't appear to consume the configured level when reporting exceptions (messaging is OK)
  2. Modify Monolog\Logger::DEBUG to Monolog\Level::Warning
  3. Constrain the default in SentryLogger::factory() to use Monolog\Level::Warning
  4. Modify examples and docs to encourage use of Warning+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant