Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sdk v4 #94

Open
lekoala opened this issue Apr 19, 2024 · 3 comments
Open

Support sdk v4 #94

lekoala opened this issue Apr 19, 2024 · 3 comments

Comments

@lekoala
Copy link
Contributor

lekoala commented Apr 19, 2024

The v4 of the sdk has been published end of last year. I was wondering if you were planning to support this?

https://github.com/getsentry/sentry-php/blob/4.0.0/UPGRADE-4.0.md

it seems at first glance that it should even be possible to support both v3/v4 in the same package

one thing i liked in the v4 is the ability to configure better the http client (for example, when testing locally, i realized the calls were not made because of the missing ca.info in my php config)

@phptek
Copy link
Owner

phptek commented Apr 22, 2024

Thanks for raising this @lekoala. If I have time, I'll look into it. So this is just a courtesy message to acknowledge the ticket at this point.

Thanks a lot :-)

@phptek
Copy link
Owner

phptek commented Apr 22, 2024

@lekoala From what you can see, does this PR appear to support the version you're thinking about? #90

@lekoala
Copy link
Contributor Author

lekoala commented Apr 22, 2024

yes indeed. i don't know if it's better to upgrade only to v4 or to do ^3 |^4 . From what i can see there is no downsides in using the updated sdk. I'll make a comment with some suggestions on the pr from some things i've realized when upgrading to the v4 in another project not using your module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants