Decorate ImpossibleCheckTypeHelper with reason #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
impossibleReason
branch
from
af42c4a
to
3088f94
Compare
VincentLanglet
commented
Oct 20, 2024
| $addTip = function (RuleErrorBuilder $ruleErrorBuilder) use ($scope, $node): RuleErrorBuilder { | ||
| $addTip = function (RuleErrorBuilder $ruleErrorBuilder) use ($scope, $node, $reasons): RuleErrorBuilder { | ||
| if (count($reasons) > 0) { | ||
| return $ruleErrorBuilder->acceptsReasonsTip($reasons); |
There was a problem hiding this comment.
I copied 6ac62d3...dc5d8f4#diff-6f5d047ab5b60f37c6dca68882f80e1f7ba2d946e0ffb91290d39589cf55acc2R58-R60
but looking at the failing test, I feel like we want to keep the treatPhpDocTypesAsCertainTip @ondrejmirtes , no ?
(So maybe the StrictComparisonOfDifferentTypesRule too ?)
Currently I dunno if I need to
- Update the tests.
- Or update this line of code.
Your call.
Comment on lines
+1113
to
+1115
| "• 'publishDate' is not lowercase. | ||
| • 'approvedAt' is not lowercase. | ||
| • 'allowedValues' is not lowercase.", |
There was a problem hiding this comment.
Since the comparison is between 'publishDate'|'approvedAt'|'allowedValues' and lowercase string, and because of how UnionType::isSuperTypeOfWithReason works
$result = IsSuperTypeOfResult::createNo()->or(...array_map(static fn (Type $innerType) => $innerType->isSuperTypeOfWithReason($otherType), $this->types));
if ($result->yes()) {
return $result;
}
we have a list with three reasons.
Is it ok for you @ondrejmirtes ?
VincentLanglet
force-pushed
the
impossibleReason
branch
from
d012b6a
to
0543a24
Compare
VincentLanglet
force-pushed
the
impossibleReason
branch
from
0543a24
to
0087cd2
Compare
|
This pull request has been marked as ready for review. |
|
Not sure it's a satisfying solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#11799