Early return in UnionType->isSuperTypeOf()

phpstan · Nov 30, 2024 · 702b422 · 702b422
1 parent 14d2bed
commit 702b422
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/Type/UnionType.php b/src/Type/UnionType.php
@@ -244,10 +244,15 @@ public function isSuperTypeOf(Type $otherType): IsSuperTypeOfResult
 			return $otherType->isSubTypeOf($this);
 		}
 
-		$result = IsSuperTypeOfResult::createNo()->or(...array_map(static fn (Type $innerType) => $innerType->isSuperTypeOf($otherType), $this->types));
-		if ($result->yes()) {
-			return $result;
+		$results = [];
+		foreach ($this->types as $innerType) {
+			$result = $innerType->isSuperTypeOf($otherType);
+			if ($result->yes()) {
+				return $result;
+			}
+			$results[] = $result;
 		}
+		$result = IsSuperTypeOfResult::createNo()->or(...$results);
 
 		if ($otherType instanceof TemplateUnionType) {
 			return $result->or($otherType->isSubTypeOf($this));