From 1d3f4313955dc6fa5c6ce60fa58afe765964e5b0 Mon Sep 17 00:00:00 2001
From: Ondrej Mirtes <ondrej@mirtes.cz>
Date: Tue, 1 Oct 2024 09:19:43 +0200
Subject: [PATCH] Collected PHP errors cannot be ignored

---
 src/Analyser/FileAnalyser.php | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/Analyser/FileAnalyser.php b/src/Analyser/FileAnalyser.php
index 8d8cf59016..570c637092 100644
--- a/src/Analyser/FileAnalyser.php
+++ b/src/Analyser/FileAnalyser.php
@@ -31,6 +31,7 @@
 use const E_NOTICE;
 use const E_PARSE;
 use const E_STRICT;
+use const E_USER_DEPRECATED;
 use const E_USER_ERROR;
 use const E_USER_NOTICE;
 use const E_USER_WARNING;
@@ -322,7 +323,7 @@ private function collectErrors(array $analysedFiles): void
 
 			$errorMessage = sprintf('%s: %s', $this->getErrorLabel($errno), $errstr);
 
-			$this->allPhpErrors[] = (new Error($errorMessage, $errfile, $errline, true))->withIdentifier('phpstan.php');
+			$this->allPhpErrors[] = (new Error($errorMessage, $errfile, $errline, false))->withIdentifier('phpstan.php');
 
 			if ($errno === E_DEPRECATED) {
 				return true;
@@ -332,7 +333,7 @@ private function collectErrors(array $analysedFiles): void
 				return true;
 			}
 
-			$this->filteredPhpErrors[] = (new Error($errorMessage, $errfile, $errline, true))->withIdentifier('phpstan.php');
+			$this->filteredPhpErrors[] = (new Error($errorMessage, $errfile, $errline, $errno === E_USER_DEPRECATED))->withIdentifier('phpstan.php');
 
 			return true;
 		});
@@ -354,12 +355,16 @@ private function getErrorLabel(int $errno): string
 				return 'Parse error';
 			case E_NOTICE:
 				return 'Notice';
+			case E_DEPRECATED:
+				return 'Deprecated';
 			case E_USER_ERROR:
 				return 'User error (E_USER_ERROR)';
 			case E_USER_WARNING:
 				return 'User warning (E_USER_WARNING)';
 			case E_USER_NOTICE:
 				return 'User notice (E_USER_NOTICE)';
+			case E_USER_DEPRECATED:
+				return 'Deprecated (E_USER_DEPRECATED)';
 			case E_STRICT:
 				return 'Strict error (E_STRICT)';
 		}