Warn when trying to cover an interface.

phpstan · Mar 25, 2023 · 9e1b9de · 9e1b9de
1 parent ceea85e
commit 9e1b9de
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/src/Rules/PHPUnit/CoversHelper.php b/src/Rules/PHPUnit/CoversHelper.php
@@ -95,6 +95,13 @@ public function processCovers(
 		if ($this->reflectionProvider->hasClass($className)) {
 			$class = $this->reflectionProvider->getClass($className);
 
+			if ($class->isInterface()) {
+				$errors[] = RuleErrorBuilder::message(sprintf(
+					'@covers value %s references an interface.',
+					$fullName
+				))->build();
+			}
+
 			if (isset($method) && $method !== '' && !$class->hasMethod($method)) {
 				$errors[] = RuleErrorBuilder::message(sprintf(
 					'@covers value %s references an invalid method.',
@@ -105,7 +112,6 @@ public function processCovers(
 			return $errors;
 		} elseif (!isset($method) && $this->reflectionProvider->hasFunction(new Name($className, []), null)) {
 			return $errors;
-
 		} else {
 			$error = RuleErrorBuilder::message(sprintf(
 				'@covers value %s references an invalid %s.',

diff --git a/tests/Rules/PHPUnit/ClassCoversExistsRuleTest.php b/tests/Rules/PHPUnit/ClassCoversExistsRuleTest.php
@@ -45,6 +45,10 @@ public function testRule(): void
 				50,
 				'The @covers annotation requires a fully qualified name.',
 			],
+			[
+				'@covers value \DateTimeInterface references an interface.',
+				64,
+			],
 		]);
 	}
 

diff --git a/tests/Rules/PHPUnit/data/class-coverage.php b/tests/Rules/PHPUnit/data/class-coverage.php
@@ -57,3 +57,10 @@ class CoversNotFullyQualified extends \PHPUnit\Framework\TestCase
 class CoversGlobalFunction extends \PHPUnit\Framework\TestCase
 {
 }
+
+/**
+ * @covers \DateTimeInterface
+ */
+class CoversInterface extends \PHPUnit\Framework\TestCase
+{
+}