Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User state file location #155

Open
mikeymike opened this issue Jul 30, 2017 · 1 comment
Open

User state file location #155

mikeymike opened this issue Jul 30, 2017 · 1 comment

Comments

@mikeymike
Copy link
Member

Currently user state is being saved in .phpschool-save.json inside the user's home dir while the workshop manager keeps itself self contained in the .php-school directory.

I think it's potentially confusing having both the .php-school directory and then the /phpschool-save.json file both inside the home dir, maybe we should persist user state inside the .php-school directory instead ?

Aside: There are potentially side effects here, we'd need to ensure the directory exists, we'd also need to add the current path to the legacy paths and process that as an array opposed to a single file as it is now. Potentially not worth effort.

@AydinHassan
Copy link
Member

Yeah I'm not sure about this. That was a lot of crappy code to migrate the settings file last time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants