Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generators/Generator.php ignores $options #118

Closed
lxg opened this issue Aug 26, 2016 · 2 comments
Closed

Generators/Generator.php ignores $options #118

lxg opened this issue Aug 26, 2016 · 2 comments

Comments

@lxg
Copy link
Contributor

lxg commented Aug 26, 2016

In version 4.0.1, the generator does not use the passed $options array when calling toString:

https://github.com/oscarotero/Gettext/blob/master/src/Generators/Generator.php#L14

Obviously, this line should read

$content = static::toString($translations, $options);
@lxg
Copy link
Contributor Author

lxg commented Aug 27, 2016 •
edited
Loading

pull request: #120

@oscarotero
Copy link
Member

Good catch! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lxg @oscarotero