Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQS Message ID #837

Closed
blocklogic-au opened this issue May 4, 2019 · 2 comments
Closed

SQS Message ID #837

blocklogic-au opened this issue May 4, 2019 · 2 comments
Labels
enhancement

Comments

@blocklogic-au
Copy link

The SQS Message handler does not set the AWS messageID to the message ID can we add

$message->setMessageId( $sqsMessage['MessageId'] );

to the SqsConsumer convertMessage() method ?

Thanks
Ben
@makasim
Copy link
Member

makasim commented May 4, 2019

LGTM

@makasim
Copy link
Member

makasim commented May 15, 2019

Feel free to send us a PR that address the issue

@makasim makasim closed this as completed May 15, 2019
@BenoitLeveque BenoitLeveque mentioned this issue Nov 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@makasim @blocklogic-au