Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc example doesn't work #783

Closed
TomPradat opened this issue Feb 25, 2019 · 5 comments
Closed

Doc example doesn't work #783

TomPradat opened this issue Feb 25, 2019 · 5 comments
Labels

Comments

@TomPradat
Copy link
Contributor

In the documentation it's written that you can instanciate a factory (for localhost) with :

$factory = new \Enqueue\AmqpLib\AmqpConnectionFactory();

Though i get an error stating that the Enqueue\Dsn\Dsn class cannot be found. Everythink works fine if i give the factory an empty array.

https://github.com/php-enqueue/enqueue-dev/blob/master/docs/transport/amqp_bunny.md

@makasim
Copy link
Member

makasim commented Feb 25, 2019

Do you use composer to install the package?

@TomPradat
Copy link
Contributor Author

TomPradat commented Feb 25, 2019

Yes i do, i tried to dump the autoloader but still had the problem. I have "enqueue/amqp-lib" as a dependency in my project

@makasim
Copy link
Member

makasim commented Feb 25, 2019

You are right. amqp-tools should require dsn pacakge. In fact it is required but in dev. https://github.com/php-enqueue/enqueue-dev/blob/master/pkg/amqp-tools/composer.json#L17

should be moved to require section.

@TomPradat
Copy link
Contributor Author

Yes indeed, do you want me to create a PR or are you handling it ?

@makasim
Copy link
Member

makasim commented Feb 25, 2019

That would be great if you could send it to us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants