New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbal] Consumer never fetches messages ordered by published time #340

Closed

f7h opened this issue Jan 21, 2018 · 1 comment

Contributor

f7h commented Jan 21, 2018

The database column "priority" is defined as NOT NULL if you use the DbalContext class to generate the schema.

The default priority of a DbalMessage is 0.

The fetchPrioritizedMessage() method from the DbalConsumer class fetches messages where the priority IS NOT NULL, so all of them.

Consequently, fetchMessage(), which fetches the oldest message first, is never called as long as there are any messages left in the queue.

The priority column should be nullable and the default priority should also be null in my opinion.

Member

makasim commented Jan 22, 2018

@f7h would you like to send us a PR?

f7h mentioned this issue

[dbal] Consumer never fetches messages ordered by published time #343

Merged

makasim closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment