Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MailService.prepareDailyStatistics(): place method to a better place #620

Closed
php-coder opened this issue Aug 2, 2017 · 0 comments
Closed

MailService.prepareDailyStatistics(): place method to a better place #620

php-coder opened this issue Aug 2, 2017 · 0 comments
Assignees
@bodom91
Labels
refactoring techdebt trivial
Milestone
0.4

Comments

@php-coder
Copy link
Owner

php-coder commented Aug 2, 2017 •
edited
Loading

MailService.prepareDailyStatistics() has no relation to mail service now. We need to find a better place for it. For example, we can create ReportService for it.

Note that after extracting method to another class, we will have a problem with getting access to it because the method has @PreAuthorize(HasAuthority.VIEW_DAILY_STATS) annotation.

Tech debt for eb57501 (#589)

CC @bodom91 in case you want to work on it
@php-coder php-coder added this to the next milestone Aug 2, 2017
@bodom91 bodom91 self-assigned this Aug 2, 2017
@bodom91 bodom91 mentioned this issue Aug 3, 2017
Closed
@php-coder php-coder modified the milestones: 0.4, next Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bodom91 bodom91

Labels
refactoring techdebt trivial
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @bodom91