Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planned Adapters #8

Closed
12 of 20 tasks
cryptiklemur opened this issue Jan 23, 2016 · 6 comments
Closed
12 of 20 tasks

Planned Adapters #8

cryptiklemur opened this issue Jan 23, 2016 · 6 comments

Comments

@Nyholm
Copy link
Member

Nyholm commented Jan 26, 2016

Awesome!

@Nyholm
Copy link
Member

Nyholm commented Jan 27, 2016

I've been thinking on a encryption adapter. Have you seen this https://github.com/jeskew/psr6-encrypting-decorator?
Is that a good package? Would you do something similar? Maybe do a merge?

@PowerKiKi
Copy link

Would the File adapter listed here be an implementation of ISAM or similar concept ? That is a single file to store everything ?

I am working on PhpSpreadsheet (PHPExcel next version) when I stumbled upon your projects and was wondering if the File here could be a (future) replacement for our DiscISAM implementation...

@Nyholm
Copy link
Member

Nyholm commented Mar 28, 2017

"File" is to store all data in one file. Not sure why this is better than "file system". Is that something you want to work on?

Im closing this issue, feel free to open new issues with requests for new adapters.

@Nyholm Nyholm closed this as completed Mar 28, 2017
@PowerKiKi
Copy link

My guess is that File would perform better if the data is very small but there is a lot of it. This is the case of PhpSpreadsheet where each data is the cell of a spreadsheet. I suppose it is faster to access a single file rather than create thousands of different very small files.

All that said, I don't intend to work on that in the foreseeable future. But I'm glad you would be open to the idea if that were the case later. Thanks !

@Nyholm
Copy link
Member

Nyholm commented Mar 29, 2017

You are correct. I've created an issue for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants