-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom theme.css and notifications.js #172
Labels
Comments
Hi @John-Henrique, Nice idea! Also, theme.css now contains notifications and preloaders. |
Hi @John-Henrique, Thank your for testing this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Are simple changes but I believe this is util. I don't made this changes because I don't know how to use gulp or the method used to make CSS styles on SRC directory, unfortunately no have time to learn now. 😓
Need add
I use this to show over screen a loading progress, so why no add a extra class to allow devs use this too? This should be in phonon.css
The spinner is other item witch can be custom, well isn't a very lol look but this is my custom right? This case, I think theme.css should become this commented and defined only border color to default.
In theme.css we have custom to tabs, panels and buttons, but not to 'determine' progress, so... 👍
Other thing, what you think about create alert, error and success classes to create a notification with progress bar stylized?
But this was bad to write and can be various params no necessary, so...
Reading the code of 'notifications.js' I note witch changes of #75 are losted in V1.3.3, but I don't know why. Yet about this changes, we need make some changes, when use (incorrect but...)
Notification freeze and not show bar progress.
theme.css have a problem with color (background is equal text) and position of button of alert
@qathom what you think?
The text was updated successfully, but these errors were encountered: