Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

iOS init option type #180

Closed
fredgalvao opened this issue Sep 30, 2015 · 4 comments · Fixed by #191
Closed

iOS init option type #180

fredgalvao opened this issue Sep 30, 2015 · 4 comments · Fixed by #191
Labels

Comments

@fredgalvao
Copy link
Collaborator

So, all examples and code samples call .init() with string options passed on the iOS part, but they're specified as Boolean on README.md. Checking source code I can see that both ways are handled, but shouldn't we either

  • pick one way and go with it
    or
  • be explicit that both ways work
    ?
@macdonst macdonst added the docs label Oct 1, 2015
@macdonst
Copy link
Member

macdonst commented Oct 1, 2015

@fredgalvao feel free to update the docs on this one.

@fredgalvao
Copy link
Collaborator Author

@macdonst Which approach is the desired one though?

@macdonst
Copy link
Member

macdonst commented Oct 1, 2015

@fredgalvao I believe in defensive programming. So if I'm expecting a boolean true I also except the String "true" to be valid. Same thing for false.

@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

2 participants