Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a NullReferenceException for F# projects #216

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

psfinaki
Copy link
Contributor

@psfinaki psfinaki commented Oct 7, 2022

That big LINQ query started to throw for F# since the first cmd-line argument is a tuple (null, null).
In tests, it's enough to just call SourceFiles.

@daveaglick
Copy link
Collaborator

Thanks for this! I'll hopefully be able to take a closer look in the next couple days.

@psfinaki
Copy link
Contributor Author

@daveaglick, sure - thanks :)

@psfinaki
Copy link
Contributor Author

A very gentle ping for a very small PR :)

@psfinaki
Copy link
Contributor Author

@safesparrow FYI

@daveaglick daveaglick merged commit d20808d into phmonte:main Oct 31, 2022
@daveaglick
Copy link
Collaborator

Done! I know you've been waiting on this, and I didn't really have a chance to review it closely, so I'm trusting the test suite and just YOLO merged. I'll get a release out momentarily.

@psfinaki psfinaki deleted the psfinaki/nre branch October 31, 2022 16:46
@psfinaki
Copy link
Contributor Author

Thanks a lot, Dave :)

@safesparrow
Copy link

@safesparrow FYI

What is the PR about? Should I be excited? :)
(I know nothing about the project, besides trying to use it for fsharp cracking)

@psfinaki
Copy link
Contributor Author

@safesparrow - well just letting you know that I'm also trying to use it for some fsharp cracking :D

NREs are generally not a very exciting matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants