Make AnalyzerResults deterministically ordered #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xced
force-pushed
the
OrderedAnalyzerResults
branch
from
12e036f
to
de8accf
Compare
|
Thanks! Looks good at first glance. Trying to get a strange test failure to clear in CI (it passes locally in Windows but not on the Windows agent, and passes the other OS agents so I'm a little perplexed) and then I'll take a closer look at this PR. |
|
I see that the test causing issues uses |
0xced
force-pushed
the
OrderedAnalyzerResults
branch
from
de8accf
to
c84c566
Compare
Skip only those that don't actually pass (using NUnit's [Platform("win")] attribute)
The order itself is not relevant (the `NuGetFrameworkSorter` used to sort target frameworks doesn't guarantee any specific order anyway) but the order is deterministic, meaning that several builds of the same project will always yield the same order of the target frameworks and results. The nondeterministic nature of the current implementation made it hard to diagnose an implementation issue in Stryker.NET: stryker-mutator/stryker-net#1899 (comment)
daveaglick
force-pushed
the
OrderedAnalyzerResults
branch
from
c84c566
to
524bfee
Compare
|
FYI - I did a rebase and force push to trigger the CI build/test reporting again. Still working on getting that just right, and seemed like the only way to restart from the refreshed GitHub Actions workflows. Assuming all the tests pass I'll get this merged. |
|
✅ It passed! 🥳 |
|
I'll get the next Buildalyzer release out momentarily. |
0xced
added a commit
to 0xced/stryker-net
that referenced
this pull request
Dec 30, 2023
Just like stryker-mutator#1900 but for the InputFileResolver. This was not an issue until phmonte/Buildalyzer#198 was reverted in phmonte/Buildalyzer@8e85a15 for the Buildalyzer 6.0.1 release. Before this change in Buildalyzer, the empty target framework was sorted last but since v6.0.1 it's sorted first instead. Also, improve the NotSupportedException message when the language is undefined because `System.NotSupportedException: Specified method is not supported` is a terrible message.
rouke-broersma
pushed a commit
to stryker-mutator/stryker-net
that referenced
this pull request
Dec 30, 2023
Make sure to select valid IAnalyzerResult from Buildalyzer Just like #1900 but for the InputFileResolver. This was not an issue until phmonte/Buildalyzer#198 was reverted in phmonte/Buildalyzer@8e85a15 for the Buildalyzer 6.0.1 release. Before this change in Buildalyzer, the empty target framework was sorted last but since v6.0.1 it's sorted first instead. Also, improve the NotSupportedException message when the language is undefined because `System.NotSupportedException: Specified method is not supported` is a terrible message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order itself is not relevant (the
NuGetFrameworkSorterused to sort target frameworks doesn't guarantee any specific order anyway) but the order is deterministic, meaning that several builds of the same project will always yield the same order of the target frameworks and results.The nondeterministic nature of the current implementation made it hard to diagnose an implementation issue in Stryker.NET: stryker-mutator/stryker-net#1899 (comment)