Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GitHub provider) Better error message when API token is invalid #85

Closed
rieschl opened this issue Sep 10, 2020 · 0 comments · Fixed by #90
Closed

(GitHub provider) Better error message when API token is invalid #85

rieschl opened this issue Sep 10, 2020 · 0 comments · Fixed by #90
Labels
enhancement New feature or request
Milestone
2.9.1

Comments

@rieschl
Copy link

rieschl commented Sep 10, 2020

Feature Request

Q A
New Feature yes
BC Break no

Summary

It would be nice to get a specific error message when the call to the GitHub fails because of invalid credentials.
The used package raises a \Github\Exception\RuntimeException with the message Bad credentials and error code 401. That could be used to generate a nice error.
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.9.1
Development

Successfully merging a pull request may close this issue.

Provide message indicating invalid credentials phly/keep-a-changelog
2 participants
@weierophinney @rieschl