Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable size (or full-screen size) on window mode #98

Open
phkaeser opened this issue Aug 27, 2024 · 6 comments
Open

Configurable size (or full-screen size) on window mode #98

phkaeser opened this issue Aug 27, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@phkaeser
Copy link
Owner

As reported by in #26 by @alexmyczko : "he screen size is kind of limited to some specific size (like 1/4 of my screen) on a macbook pro with retina display"

To confirm: Is that when running in window mode, or is this in a principal wayland session?

@phkaeser phkaeser added the enhancement New feature or request label Aug 27, 2024
@alexmyczko
Copy link

it is startx with .xsessionrc exec wlmaker. a full session basically

@phkaeser
Copy link
Owner Author

Thank you for clarifying!

Please note: When running with startx, you'll be launching an X11 environment first, and wlmaker then runs as an application in that X11 session.

The purpose of wlmaker is to provide a Window Maker-like experience on Wayland without X11, so I recommend you rather run it from a virtual terminal without startx (Option 2 from https://github.com/phkaeser/wlmaker/blob/main/doc/RUN.md) .

That said: It'll be useful to permit configurable size (eg. adding --width and --height arguments) for running it in window mode, and should address the use-case of running as X11 session app.

@alexmyczko
Copy link

So the option 2 looks ok to me, but basically I'd probably just don't need the wrapper and can just run wlmaker. as it gets installed in /usr/bin which is in $PATH, likewise the settings for $LD_LIBRARY_PATH and $PKG_CONFIG_PATH.

I hope suppresing the options --width and --height, will assume full screen in the future. Counting that pixels is really hard...

@phkaeser
Copy link
Owner Author

Yes, running wlmaker from the virtual terminal (not under X11) makes it use the full output dimensions (ie. full-screen), no need for extra commandline arguments. These would be used only when running as a window (eg. under an X11 session, or from an already-running Wayland compositor).

The wrapper script is only there to set the paths when installing from source; so shouldn't be required when using the distribution's packages.

@alexmyczko
Copy link

Sorry for using it wrong…

@phkaeser
Copy link
Owner Author

#105 addresses this for X11 windows.

Pending: See how to apply this when running as a window under another Wayland compositor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants