Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard input broken #27

Open
fbruetting opened this issue Sep 1, 2019 · 7 comments
Open

Keyboard input broken #27

fbruetting opened this issue Sep 1, 2019 · 7 comments

Comments

@fbruetting
Copy link

v0.5.6-Flatpak (would be cool if you would provide an “info” screen in the program)

Here are some problems I encountered:

  • I cannot use the arrow keys to navigate through the video – at pressing those keys, I just hear that “limit reached sound” (which you also encounter in an empty terminal, when you try to scroll down when there is no newer prompt line in the history).
  • Pressing the space bar pauses the video, while the play button still shows the “pause” icon (i.e. it does not change). Pressing the space bar again does nothing.
@philn
Copy link
Owner

philn commented Sep 1, 2019

v0.5.6-Flatpak (would be cool if you would provide an “info” screen in the program)

The About menu is no longer accessible indeed since I migrated to the "sandwitch" menu. I'll keep it in mind for next release.

Here are some problems I encountered:

  • I cannot use the arrow keys to navigate through the video – at pressing those keys, I just hear that “limit reached sound” (which you also encounter in an empty terminal, when you try to scroll down when there is no newer prompt line in the history).

The shortcuts for seeking are Ctrl-Left and Ctrl-Right.

  • Pressing the space bar pauses the video, while the play button still shows the “pause” icon (i.e. it does not change). Pressing the space bar again does nothing.

I can't reproduce this issue here. Pressing space pauses the video and the pause button switches to the play icon, as expected.

@philn
Copy link
Owner

philn commented Sep 1, 2019

The current shortcuts: https://github.com/philn/glide/blob/master/src/ui_context.rs#L144
(Primary is an alias for Ctrl on Linux). It's true I should add an overlay help menu documenting those though.

@fbruetting
Copy link
Author

Why don’t you use the arrow keys directly (without Ctrl), like every other media player does? Normally these modifier keys change the timestep (normal: 10s, Shift: 1m, Alt: 5/10m, etc.). However, at least this sounds are superfluous and could be deleted, I think.

I can't reproduce this issue here. Pressing space pauses the video and the pause button switches to the play icon, as expected.

Ok, today I also can’t reproduce. This occurred after playing around with the arrow key navigation, yesterday.

@philn
Copy link
Owner

philn commented Sep 1, 2019

Why don’t you use the arrow keys directly (without Ctrl), like every other media player does? Normally these modifier keys change the timestep (normal: 10s, Shift: 1m, Alt: 5/10m, etc.). However, at least this sounds are superfluous and could be deleted, I think.

By "normally", which apps do you mean?
I've based this behavior on VLC, where pressing Left/Right seeks in the playlist, not in the media itself.

@fbruetting
Copy link
Author

Totem, Celluloid/Gnome-MPV, and all media players I ever encountered on Windows, basically. Would be new to me if the arrow keys would not work in VLC for sifting. 🤔️

I guess sifting through videos is a way more often used operation than switching videos, which is why I personally would make that the easier reachable one. For music it’s the other way round, but Glide is primary a video player, or? And as far as I can tell, Glide has no playlist feature, has it?

@philn
Copy link
Owner

philn commented Sep 1, 2019

I made this primarily for video yeah, regarding playlists, see #21

@fbruetting
Copy link
Author

As this would me a more rare case of usage for most people, would you mind switching Arrow actions with Ctrl + Arrow actions? I.e. let Arrow navigate throughout a video and Ctrl + Arrow switch between files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants