[plz rebase merge] Cache Sentry Builds to S3 #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpadaki
requested review from
npip99,
philippemnoel and
sardination
as code owners
github-actions
bot
added
the
📁 Repo: protocol
rpadaki
force-pushed
the
roshan/protocol/cache-sentry-builds-to-s3
branch
9 times, most recently
from
ebd2236 to
edf4375
Compare
Base automatically changed from
roshan/protocol/remove-global-binary-downloads
to
dev
July 30, 2021 04:03
rpadaki
force-pushed
the
roshan/protocol/cache-sentry-builds-to-s3
branch
from
edf4375 to
ce1e32b
Compare
rpadaki
changed the title
|
✔️ Deploy Preview for fractal-dev canceled. 🔨 Explore the source changes: af11cb3 🔍 Inspect the deploy log: https://app.netlify.com/sites/fractal-dev/deploys/6104296adf1f50000759fdd9 |
philippemnoel
previously approved these changes
Jul 30, 2021
djsavvy
previously approved these changes
Jul 30, 2021
sardination
previously approved these changes
Jul 30, 2021
rpadaki
dismissed stale reviews from sardination, djsavvy, and philippemnoel
via
8369e5a
rpadaki
force-pushed
the
roshan/protocol/cache-sentry-builds-to-s3
branch
2 times, most recently
from
8369e5a to
af11cb3
Compare
djsavvy
approved these changes
Jul 30, 2021
philippemnoel
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should greatly reduce protocol build time by building Sentry ahead of time! Note that this PR should go after #3388.
Implementation
I first wrote a workflow job to build Sentry/Crashpad on Windows/Linux/macOS. Then, I added Sentry to our protocol
cmakewhile removing the old Sentry pipeline.Importantly, we have to make sure not to build Sentry tests on Windows, since there's an outstanding issue solved by getsentry/sentry-native#583. Once that fix is in, we can bump our Sentry version to make our CI a little more robust, though I don't think we want to build tests in any case.
Note that Sentry by default builds with
-O3, as I manually confirmed in itscmakeconfiguration. I only chose build typeReleaseto get rid of debug symbols.