Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.4.0 breaks on case-sensitive filesystems (i.e. Linux) #30

Closed
TooTallNate opened this issue Jun 26, 2023 · 15 comments
Closed

v2.4.0 breaks on case-sensitive filesystems (i.e. Linux) #30

TooTallNate opened this issue Jun 26, 2023 · 15 comments

Comments

@TooTallNate
Copy link

The PR #29 seems to have broken on case-sensitive filesystems, due to this change in casing in the import call:

Screenshot 2023-06-26 at 4 34 22 PM

Noticed this by trying to deploy a Storybook application, which has started failing at build-time.

@TooTallNate
Copy link
Author

I see that the filename was also renamed to be lowercase, so the code itself should be fine. This is probably an issue with your local build which was then published, so I suggest trying to clear out any build artifacts and then trying to build again (and publish a fixed version 😄).

@zombieJ
Copy link

zombieJ commented Jun 27, 2023

https://unpkg.com/browse/[email protected]/lib/common/

npm still keep the upcase:

截屏2023-06-27 11 34 10

@augustobmoura
Copy link

This is a big deal, I can't run storybook cli from npx because it resolves to the latest file-system-cache and that is broken on linux.

Quick reproduction steps:

docker run -it --rm node:16 npx -y storybook@latest --version

It looks like the paths are correct on master, but for some reason the file was capitalized on the computer that made the release. I assume making a new release from a newly cloned repo should fix it.

@philcockfield could you please make a new release?

@dzek69
Copy link

dzek69 commented Jun 27, 2023

For anyone looking for a workaround for storybook init:

  • install it as a normal dependecy like pnpm add storybook - you will need it anyway (update the command for yarn/npm/whatever you use)
  • fix the filename somewhere in the node_modules folder (the path depends on package manager, so again - adjust for what you use)
  • run pnpm exec storybook init
  • 🎉

@joriswitteman
Copy link

FWIW a workaround is present in Storybook 7.0.24, just waiting for the release to pass their CI/CD

@JReinhold
Copy link

Storybook v7.0.24 has now been released that should workaround this issue for now.

@trevor-vaughan
Copy link

Confirmed on independent use of the library. Renaming the file from Util.js to util.js resolves the issue.

@mike-potter
Copy link

Also just ran into this. This is super critical. Rather than patching downstream dependencies can we get a new release of file-system-cache that fixes this asap? Confirmed that renaming the file to util.js solves it.

@mike-potter
Copy link

mike-potter commented Jun 27, 2023

If it's an npm package issue, maybe going back to the uppercase Util.js (and updating the import statement) would be better until a better fix can be found.

@dep
Copy link

dep commented Jun 27, 2023

@JReinhold I still get the error with Storybook 7.0.24

@storybook/cli v7.0.24

info => Cleaning outputDir: /storybook-static/src
info => Loading presets
ERR! Error: Cannot find module './util'

Update: There was a dep I missed! bringing it to 7.0.24 worked :)

@mike-potter
Copy link

Storybook 7.0.24 works for me here, but I had to clean my yarn cache, remove my lock file and node_modules folder to get a fresh build of dependencies.

@mike-potter
Copy link

Do a yarn list --pattern file-system-cache to see if you are getting the 2.3.0 version that works.

@philcockfield
Copy link
Owner

philcockfield commented Jun 27, 2023

Published patch to NPM → 2.4.1
Sincerest apologies for that SNAFU everyone! 😳

@philcockfield
Copy link
Owner

I'll leave this open for a little while - please sing out if anyone's having further problems related to this.

@philcockfield
Copy link
Owner

Cool, no more comments, so looks like this is sorted. Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants