-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.4.0 breaks on case-sensitive filesystems (i.e. Linux) #30
Comments
I see that the filename was also renamed to be lowercase, so the code itself should be fine. This is probably an issue with your local build which was then published, so I suggest trying to clear out any build artifacts and then trying to build again (and publish a fixed version 😄). |
https://unpkg.com/browse/[email protected]/lib/common/ npm still keep the upcase: |
This is a big deal, I can't run storybook cli from npx because it resolves to the latest file-system-cache and that is broken on linux. Quick reproduction steps: docker run -it --rm node:16 npx -y storybook@latest --version It looks like the paths are correct on master, but for some reason the file was capitalized on the computer that made the release. I assume making a new release from a newly cloned repo should fix it. @philcockfield could you please make a new release? |
For anyone looking for a workaround for storybook init:
|
FWIW a workaround is present in Storybook 7.0.24, just waiting for the release to pass their CI/CD |
Storybook v7.0.24 has now been released that should workaround this issue for now. |
Confirmed on independent use of the library. Renaming the file from |
Also just ran into this. This is super critical. Rather than patching downstream dependencies can we get a new release of |
If it's an npm package issue, maybe going back to the uppercase |
@JReinhold I still get the error with Storybook @storybook/cli v7.0.24
Update: There was a dep I missed! bringing it to |
Storybook 7.0.24 works for me here, but I had to clean my yarn cache, remove my lock file and node_modules folder to get a fresh build of dependencies. |
Do a |
Published patch to NPM → 2.4.1 |
I'll leave this open for a little while - please sing out if anyone's having further problems related to this. |
Cool, no more comments, so looks like this is sorted. Thanks all. |
The PR #29 seems to have broken on case-sensitive filesystems, due to this change in casing in the import call:
Noticed this by trying to deploy a Storybook application, which has started failing at build-time.
The text was updated successfully, but these errors were encountered: