Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing Post: Pass -serial stdio instead of -serial mon:stdio to QEMU #602

Closed
phil-opp opened this issue May 7, 2019 · 4 comments
Closed

Testing Post: Pass -serial stdio instead of -serial mon:stdio to QEMU #602

phil-opp opened this issue May 7, 2019 · 4 comments

Comments

@phil-opp
Copy link
Owner

phil-opp commented May 7, 2019

The former allows exiting through normal crtl+c, but I'm not sure from the QEMU docs if it works with windows.
@AntoineSebert
Copy link
Contributor

AntoineSebert commented May 7, 2019 •
edited
Loading

I could exit with ctrl+c after running cargo xrun. I also got this message, but that was expected:

error: process didn't exit successfully: `bootimage runner 'target\x86_64-blog_os\debug\blog_os'` (exit code: 0xc000013a, STATUS_CONTROL_C_EXIT)

Operating system : Windows 10
Edition : Family
Version : 1809
OS build : 17.763,475

@phil-opp phil-opp changed the title Pass -serial stdio instead of -serial mon:stdio to QEMU Testing Post: Pass -serial stdio instead of -serial mon:stdio to QEMU May 8, 2019
@phil-opp
Copy link
Owner Author

phil-opp commented May 8, 2019

@AntoineSebert Thanks for testing! Exiting cargo xrun with ctrl+c should work fine. We currently pass the -serial mon:stdio argument as test-args, so it only applies to xtest.

Given that you're using windows: Could you try adding a endless loop in a test and test whether you can exit cargo xtest? How about when you change the test-args in your Cargo.toml from -serial mon:stdio instead of -serial stdio?

@AntoineSebert
Copy link
Contributor

ctrl+c -serial mon:stdio -serial stdio
lööp ✔️ ✔️
normal ✔️ ✔️

Infinite loop added to test_breakpoint_exception() and implemented as loop {}.

@phil-opp
Copy link
Owner Author

phil-opp commented May 8, 2019

Thanks for checking!

@phil-opp phil-opp mentioned this issue May 9, 2019
Merged
bors bot added a commit that referenced this issue May 9, 2019
@bors @phil-opp
Merge #604 #606
158aed0 
604: Use `-serial stdio` instead of `-serial mon:stdio` r=phil-opp a=phil-opp

Fixes #602 

Post update in #605

606: Update x86_64 to version 0.7.0 r=phil-opp a=phil-opp

[Changelog](https://github.com/rust-osdev/x86_64/blob/master/Changelog.md#070):

- **Breaking**: `Port::read` and `PortReadOnly::read` now take `&mut self` instead of `&self` ([#76](rust-osdev/x86_64#76)).

Post update in #607

Co-authored-by: Philipp Oppermann <[email protected]>
@phil-opp phil-opp closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phil-opp @AntoineSebert