From 0447f08c7ba77027a5ebd634db7d461d4c267092 Mon Sep 17 00:00:00 2001
From: Robert Oskamp <robert.oskamp@elastic.co>
Date: Tue, 12 Nov 2019 06:04:50 -0500
Subject: [PATCH] [ML] Make navigation in tests more stable (#50132)

This PR fixes the ML navigation.
---
 .../services/machine_learning/navigation.ts   | 26 +++++++++----------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/x-pack/test/functional/services/machine_learning/navigation.ts b/x-pack/test/functional/services/machine_learning/navigation.ts
index a55eae9122485..06ab99b3dcb9f 100644
--- a/x-pack/test/functional/services/machine_learning/navigation.ts
+++ b/x-pack/test/functional/services/machine_learning/navigation.ts
@@ -32,12 +32,10 @@ export function MachineLearningNavigationProvider({
     },
 
     async navigateToArea(linkSubject: string, pageSubject: string) {
-      await retry.tryForTime(2 * 60 * 1000, async () => {
-        if ((await testSubjects.exists(`${linkSubject} selected`)) === false) {
-          await testSubjects.click(linkSubject);
-          await testSubjects.existOrFail(`${linkSubject} selected`, { timeout: 30 * 1000 });
-          await testSubjects.existOrFail(pageSubject, { timeout: 30 * 1000 });
-        }
+      await testSubjects.click(linkSubject);
+      await retry.tryForTime(60 * 1000, async () => {
+        await testSubjects.existOrFail(`${linkSubject} & ~selected`);
+        await testSubjects.existOrFail(pageSubject);
       });
     },
 
@@ -51,11 +49,11 @@ export function MachineLearningNavigationProvider({
     },
 
     async navigateToOverview() {
-      await this.navigateToArea('mlMainTab overview', 'mlPageOverview');
+      await this.navigateToArea('~mlMainTab & ~overview', 'mlPageOverview');
     },
 
     async navigateToAnomalyDetection() {
-      await this.navigateToArea('mlMainTab anomalyDetection', 'mlPageJobManagement');
+      await this.navigateToArea('~mlMainTab & ~anomalyDetection', 'mlPageJobManagement');
       await this.assertTabsExist('mlSubTab', [
         'jobManagement',
         'anomalyExplorer',
@@ -65,33 +63,33 @@ export function MachineLearningNavigationProvider({
     },
 
     async navigateToDataFrameAnalytics() {
-      await this.navigateToArea('mlMainTab dataFrameAnalytics', 'mlPageDataFrameAnalytics');
+      await this.navigateToArea('~mlMainTab & ~dataFrameAnalytics', 'mlPageDataFrameAnalytics');
       await this.assertTabsExist('mlSubTab', []);
     },
 
     async navigateToDataVisualizer() {
-      await this.navigateToArea('mlMainTab dataVisualizer', 'mlPageDataVisualizerSelector');
+      await this.navigateToArea('~mlMainTab & ~dataVisualizer', 'mlPageDataVisualizerSelector');
       await this.assertTabsExist('mlSubTab', []);
     },
 
     async navigateToJobManagement() {
       await this.navigateToAnomalyDetection();
-      await this.navigateToArea('mlSubTab jobManagement', 'mlPageJobManagement');
+      await this.navigateToArea('~mlSubTab & ~jobManagement', 'mlPageJobManagement');
     },
 
     async navigateToAnomalyExplorer() {
       await this.navigateToAnomalyDetection();
-      await this.navigateToArea('mlSubTab anomalyExplorer', 'mlPageAnomalyExplorer');
+      await this.navigateToArea('~mlSubTab & ~anomalyExplorer', 'mlPageAnomalyExplorer');
     },
 
     async navigateToSingleMetricViewer() {
       await this.navigateToAnomalyDetection();
-      await this.navigateToArea('mlSubTab singleMetricViewer', 'mlPageSingleMetricViewer');
+      await this.navigateToArea('~mlSubTab & ~singleMetricViewer', 'mlPageSingleMetricViewer');
     },
 
     async navigateToSettings() {
       await this.navigateToAnomalyDetection();
-      await this.navigateToArea('mlSubTab settings', 'mlPageSettings');
+      await this.navigateToArea('~mlSubTab & ~settings', 'mlPageSettings');
     },
   };
 }