Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation emitters have different tenses #13

Open
samreid opened this issue Apr 24, 2018 · 1 comment
Open

Animation emitters have different tenses #13

samreid opened this issue Apr 24, 2018 · 1 comment
Assignees

Comments

@samreid
Copy link
Member

samreid commented Apr 24, 2018

From #11

The emitters are:

    this.startEmitter = new Emitter();
    this.beginEmitter = new Emitter();
    this.finishEmitter = new Emitter();
    this.stopEmitter = new Emitter();
    this.endedEmitter = new Emitter();
    this.updateEmitter = new Emitter();

Perhaps we should rename endedEmitter => endEmitter unless there is a good reason for the inconsistency?

@pixelzoom
Copy link
Contributor

+1 to rename endedEmitter => endEmitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants