From e484b1a294522095e9137fb508a5ef1bafef2c25 Mon Sep 17 00:00:00 2001
From: Jesse <jesse.greenberg@colorado.edu>
Date: Thu, 12 Dec 2024 18:12:50 -0500
Subject: [PATCH] use FractionNode for the second pi display, see
 https://github.com/phetsims/trig-tour/issues/80

---
 js/trig-tour/view/readout/AngleReadoutRow.ts | 22 ++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/js/trig-tour/view/readout/AngleReadoutRow.ts b/js/trig-tour/view/readout/AngleReadoutRow.ts
index 9fb449b..8784014 100644
--- a/js/trig-tour/view/readout/AngleReadoutRow.ts
+++ b/js/trig-tour/view/readout/AngleReadoutRow.ts
@@ -238,7 +238,7 @@ class AngleReadoutRow extends Node {
     }
 
     this.fullAngleFractionNode.setValues( fullTurnString, '', false );
-    this.angleReadoutFraction.left = this.fullAngleFractionNode.right;
+    this.angleReadoutFraction.left = this.fullAngleFractionNode.right + 4;
 
     // set the angle readout, making sure that the angle is defined in the special fractions object
     const specialAngleFractions = SpecialAngles.SPECIAL_ANGLE_FRACTIONS;
@@ -258,6 +258,7 @@ class AngleReadoutRow extends Node {
     }
 
     // Must handle smallAngle = 0 or pi as special cases
+    let useFractionNode = false;
     const roundedAngle = Utils.roundSymmetric( this.trigTourModel.getSmallAngleInDegrees() );
     if ( roundedAngle === 0 || roundedAngle === 180 ) {
       const halfTurnCount = this.trigTourModel.halfTurnCount;
@@ -288,9 +289,12 @@ class AngleReadoutRow extends Node {
         // The display needs to change if the angle is negative. For example, it should be
         // 2pi + pi (angle positive) OR
         // -2pi - pi (angle negative)
-        const additionalPiSign = angleNegative ? '-' : '+';
-        const minusSign = angleNegative ? '-' : '';
-        numberOfPiRadiansString = `${minusSign}${Math.abs( halfTurnCount ) - 1}${MathSymbols.PI} ${additionalPiSign} ${MathSymbols.PI}`;
+        const sign = angleNegative ? '-' : ''; // a minus sign is drawn as a custom line in the FractionNode, if this dash is added
+        numberOfPiRadiansString = `${sign}${Math.abs( halfTurnCount ) - 1}${MathSymbols.PI}`;
+
+        // The fraction Node will be used to show the additional pi sign.
+        useFractionNode = true;
+        this.angleReadoutFraction.setValues( `${sign}${MathSymbols.PI}`, '' );
       }
       else {
 
@@ -301,8 +305,14 @@ class AngleReadoutRow extends Node {
       this.fullAngleFractionNode.setValues( numberOfPiRadiansString, '' );
 
       // dummy angleReadoutFraction is set to ensure bounds remain constant and readoutDisplay does not jump around
-      this.angleReadoutFraction.setValues( 'A', 'B' );
-      this.angleReadoutFraction.visible = false;
+      if ( useFractionNode ) {
+        this.angleReadoutFraction.visible = true;
+        this.angleReadoutFraction.left = this.fullAngleFractionNode.right + 9.5;
+      }
+      else {
+        this.angleReadoutFraction.setValues( 'A', 'B' );
+        this.angleReadoutFraction.visible = false;
+      }
     }
   }
 }